Skip to content

Fix improper imports from index files #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ThomasMichon merged 2 commits into from
Apr 17, 2018
Merged

Fix improper imports from index files #4585

ThomasMichon merged 2 commits into from
Apr 17, 2018

Conversation

@ThomasMichon
Copy link
Member

@ThomasMichon ThomasMichon commented Apr 17, 2018

Various downstream build systems cannot handle imports from /index files, so they need to be removed from this repository. Updated recently-added code to point to direct modules where appropriate.

manishgarg1
manishgarg1 approved these changes Apr 17, 2018
View reviewed changes
Copy link
Collaborator

@manishgarg1 manishgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@manishgarg1 manishgarg1 self-assigned this Apr 17, 2018
@ThomasMichon ThomasMichon merged commit 4dc9071 into microsoft:master Apr 17, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@manishgarg1 manishgarg1 manishgarg1 approved these changes

@joschect joschect joschect approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@manishgarg1 manishgarg1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasMichon @manishgarg1 @joschect